Thread (2 messages) 2 messages, 2 authors, 2017-07-31
STALE3284d

[PATCH] dev: fix dev_attach proceeding with vdev on success

From: Gaetan Rivet <hidden>
Date: 2017-07-26 11:52:36
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

When rte_eal_hotplug_add() successfully probe a device, the return value
is zero. The check afterward only returns on error different from
-EINVAL. It should return also on success, as there is no need to
attempt probing the device with vdev.

Fixes: 0bba9e605048 ("eal: use new hotplug API in attach")
Cc: stable@dpdk.org
Cc: Jan Blunck <redacted>

Signed-off-by: Gaetan Rivet <redacted>
---
 lib/librte_eal/common/eal_common_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
index e10b9fd..d74f978 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -74,7 +74,7 @@ int rte_eal_dev_attach(const char *name, const char *devargs)
 	}
 
 	ret = rte_eal_hotplug_add("pci", name, devargs);
-	if (ret && ret != -EINVAL)
+	if (ret != -EINVAL)
 		return ret;
 
 	/*
-- 
2.1.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help