Thread (8 messages) read the whole thread 8 messages, 3 authors, 2017-07-31

Re: [PATCH 0/2] fix flow rules copy functions

From: Adrien Mazarguil <hidden>
Date: 2017-07-24 09:00:47

On Mon, Jul 24, 2017 at 10:10:20AM +0300, Matan Azrad wrote:
some issue seen when trying to test failsafe plug out and in. 

Matan Azrad (2):
  app/testpmd: fix flow rule copy functions
  ethdev: fix flow rule copy functions

 app/test-pmd/config.c       | 16 ++++++++++------
 lib/librte_ether/rte_flow.c | 16 ++++++++++------
 2 files changed, 20 insertions(+), 12 deletions(-)
Thanks!

I think the original code didn't have these functions and used the
flow_item[x].size value directly, which worked fine until I added support
for the RAW item and the RSS action. Both had to be handled through special
functions which I messed up.

Unfortunately I didn't catch it in testpmd because it doesn't do anything
with the copied data unlike the fail-safe PMD.

Acked-by: Adrien Mazarguil <redacted>

-- 
Adrien Mazarguil
6WIND
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help