Re: [PATCH 0/8] bnxt patchset
From: Ferruh Yigit <hidden>
Date: 2017-07-20 10:02:52
On 7/20/2017 5:48 AM, Ajit Khaparde wrote:
Hi, This patch set fixes some of the issues found during testing. Please apply. Thanks net/bnxt: fix log levels for non error conditions. net/bnxt: fix to avoid a segfault net/bnxt: fix vnic cleanup net/bnxt: fix set link config net/bnxt: reset VF stats during initialization net/bnxt: fix VLAN antispoof configuration code net/bnxt: check invalid l2_filter_id net/bnxt: fix to free a filter before reusing it
Getting following build errors, fyi:
.../drivers/net/bnxt/rte_pmd_bnxt.c:464:8: error: variable 'rc' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (bnxt_hwrm_cfa_l2_set_rx_mask(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use
occurs here
return rc;
^~
.../drivers/net/bnxt/rte_pmd_bnxt.c:464:4: note: remove the 'if' if its
condition is always true
if (bnxt_hwrm_cfa_l2_set_rx_mask(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:462:7: error: variable 'rc' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (bnxt_hwrm_vnic_qcfg(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use
occurs here
return rc;
^~
.../drivers/net/bnxt/rte_pmd_bnxt.c:462:3: note: remove the 'if' if its
condition is always true
if (bnxt_hwrm_vnic_qcfg(bp, &vnic,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:454:6: error: variable 'rc' is used
uninitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
if (dflt_vnic < 0) {
^~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use
occurs here
return rc;
^~
.../drivers/net/bnxt/rte_pmd_bnxt.c:454:2: note: remove the 'if' if its
condition is always false
if (dflt_vnic < 0) {
^~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/rte_pmd_bnxt.c:440:8: note: initialize the variable
'rc' to silence this warning
int rc;
^
= 0
3 errors generated.