Re: [PATCH] net/virtio: fix fail to configure rxq interrupt
From: Yang, Zhiyong <hidden>
Date: 2017-07-19 03:23:48
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu
Sent: Wednesday, July 19, 2017 11:18 AM
To: dev@dpdk.org
Cc: Tan, Jianfeng <redacted>; yliu@fridaylinux.org; Yao, Lei A
[off-list ref]; Hu, Jiayu [off-list ref]; stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt
When use rte_eth_dev_configure() to enable rx queue interrupt for virtio devices,
virtio_configure_intr() isn't called to set up the interrupt environment, which
causes rx queue interrupt setup failed. This patch is to fix this issue.
Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts")
Cc: stable@dpdk.org
Signed-off-by: Jiayu Hu <redacted>
---
drivers/net/virtio/virtio_ethdev.c | 7 +++++++
1 file changed, 7 insertions(+)Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com > Thanks Zhiyong
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 00a3122..66656ed 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c@@ -1688,6 +1688,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) return -ENOTSUP; } + if (dev->data->dev_conf.intr_conf.rxq) { + if (virtio_configure_intr(dev) < 0) { + PMD_DRV_LOG(ERR, "failed to configure interrupt"); + return -ENOTSUP; + } + } + if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) /* Enable vector (0) for Link State Intrerrupt */ if (VTPCI_OPS(hw)->set_config_irq(hw, 0) == --2.7.4