Re: [PATCH v7 00/17] Generic devargs parsing
From: Jan Blunck <hidden>
Date: 2017-07-09 08:37:41
On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon [off-list ref] wrote:
07/07/2017 02:04, Gaetan Rivet:quoted
In this patchset, the representation of devices in rte_devargs is made generic to remove some dependencies of the EAL on specific buses implementations. Following the device types being characterized by their bus, the DEVTYPE flags are updated not to reference virtual / PCI devices anymore.[...]quoted
Gaetan Rivet (16): net/bonding: properly reference PCI header net/bnxt: properly reference PCI header net/mlx5: properly reference PCI header net/e1000: properly reference PCI header net/ixgbe: properly reference PCI header net/sfc: properly reference PCI header app/testpmd: properly reference PCI header test: properly reference PCI header dev: device kernel module is a device attribute bus: introduce bus scan policies devargs: parse bus policies devargs: generic device representation net/virtio: do not reference device type devargs: generic device types devargs: introduce cleaner parsing helper eal: change whitelist / blacklist command line doc Thomas Monjalon (1): examples/ethtool: properly reference PCI headerSeries applied, except last patch (17), as explained before. Thanks
I wonder why you complain about not having enough reviewers if you anyway ignoring their feedback! I pointed out multiple times that parsing a device name to deduce the bus is not the right thing to do. This series also tightly couples rte_devargs to rte_bus. It adds hidden functionality to have blacklist/whitelist mode for all busses and even sticks that functionality on the wrong object (devargs).