Re: [PATCH v2] examples/vhost: introduce a new vhost-user-scsi sample application

-----Original Message-----
From: Yuanhan Liu [mailto:yliu@fridaylinux.org]
Sent: Friday, July 7, 2017 12:49 PM
To: Liu, Changpeng <redacted>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: introduce a new vhost-user-
scsi sample application

On Sat, Jul 08, 2017 at 12:14:51PM +0800, Changpeng Liu wrote:

quoted

+.. note::
+    You must check whether your Qemu can support "vhost-user-scsi" or not,
+    Qemu v2.9.50 or newer version is required.

QEMU v2.9.50 looks like a stable version, and I don't think they will
backport new features on it (or, do they?).

No backport plans.

So, it should be "v2.10" here?

v2.10 should be fine.

quoted

+		switch (pc) {
+		case SPC_VPD_SUPPORTED_VPD_PAGES:
+			hlen = 4;
+			vpage->params[0] = SPC_VPD_SUPPORTED_VPD_PAGES;
+			vpage->params[1] = SPC_VPD_UNIT_SERIAL_NUMBER;
+			vpage->params[2] = SPC_VPD_DEVICE_IDENTIFICATION;
+			len = 3;
+			/* PAGE LENGTH */
+			to_be16(vpage->alloc_len, len);
+		break;

You didn't resolve my previous comment regarding the "break"
indentation issue.

Didn't notice here, will do it with v3.

Otherwise, this patch looks good to me.

	--yliu