Thread (51 messages) 51 messages, 5 authors, 2017-07-06

Re: [PATCH v7 3/4] net/mlx4: refactor RSS parent queue allocation

From: Adrien Mazarguil <hidden>
Date: 2017-07-04 15:21:04

On Tue, Jul 04, 2017 at 11:22:50AM +0000, Vasily Philipov wrote:
A special "parent" queue must be allocated in addition to a group of
standard Rx queues for RSS to work. This is done automatically outside of
isolated mode by the PMD when applications request several Rx queues.

Since each configured flow rule with the RSS action may target a different
set of queues, the PMD must have the ability to dynamically allocate
several parent queues, one per RSS group.

If isolated mode was requested the default RSS parent queue isn't created
in this case.

Refactor RSS parent queue allocations (currently limited to a single
parent) in preparation for flow API RSS action support.

Signed-off-by: Vasily Philipov <redacted>
Thanks for making the requested changes.

There is a remaining issue with this patch, creating a flow in isolated mode
causes a crash due to RX QPs not being allocated. You should temporarily
make priv_flow_create_action_queue() call rxq_create_qp() when the target QP
does not exist.

Patch looks otherwise fine.

-- 
Adrien Mazarguil
6WIND
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help