Re: [PATCH v2 0/4] AESNI GCM PMD: Migration from ISA-L to Multi-buffer library
From: De Lara Guarch, Pablo <hidden>
Date: 2017-07-04 10:11:18
-----Original Message----- From: Gonzalez Monroy, Sergio Sent: Friday, June 30, 2017 3:17 PM To: De Lara Guarch, Pablo <redacted>; Doherty, Declan [off-list ref] Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] AESNI GCM PMD: Migration from ISA-L to Multi-buffer library On 28/06/2017 12:32, Pablo de Lara wrote:quoted
AES-NI GCM PMD migrated previously from Multi-buffer Crypto library to ISA-L Crypto library, to support several features that were not supported by that time, such as GMAC algorithm and Scatter-gather list. Since version 0.45, Multi-buffer library (https://github.com/01org/intel-ipsec-mb) supports all these features, the PMD can link against this library again(version 0.46 now).quoted
This will improve maintainability, as now AESNI GCM PMD will share the same library as AESNI MB PMD, having one less library to link against. Italso adds support for 192-bit keys.quoted
In terms of performance, it has been improved, especially for somearchitectures.quoted
This patchset is migrating the PMD to link against Multi-buffer libraryv0.46.quoted
Changes in v2: - Supported Multi-buffer 0.46 library - Added new tests to other PMD testsuites - Rebased against latest dpdk-next-crypto code Pablo de Lara (4): crypto/aesni_gcm: migrate to Multi-buffer library test/crypto: rename some tests test/crypto: add AES GCM 192 tests test/crypto: extend AES-GCM 192/256 to other PMDs devtools/test-build.sh | 4 +- doc/guides/cryptodevs/aesni_gcm.rst | 18 +- doc/guides/cryptodevs/features/aesni_gcm.ini | 4 +- doc/guides/rel_notes/release_17_08.rst | 8 + drivers/crypto/aesni_gcm/Makefile | 9 +- drivers/crypto/aesni_gcm/aesni_gcm_ops.h | 97 ++++- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 98 +++-- drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 18 +- drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h | 32 +- mk/rte.app.mk | 3 +- test/test/test_cryptodev.c | 497 +++++++++++++++++------ test/test/test_cryptodev_gcm_test_vectors.h | 357++++++++++++++++quoted
12 files changed, 922 insertions(+), 223 deletions(-)Series Acked-by: Sergio Gonzalez Monroy [off-list ref]
Applied to dpdk-next-crypto. Pablo