Re: [PATCH v2 7/8] net/qede: add missing check for VNI
From: Ferruh Yigit <hidden>
Date: 2017-07-03 10:08:48
On 7/1/2017 8:30 PM, Rasesh Mody wrote:
Add missing check for VNI field while adding unicast filter.
Can you please document the result of not having vni field? And if this is fixing an error, can you please use fixes syntax?
quoted hunk ↗ jump to hunk
Signed-off-by: Rasesh Mody <redacted> --- drivers/net/qede/qede_ethdev.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index ad264ba..a0616a4 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c@@ -571,6 +571,7 @@ static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn, SLIST_FOREACH(tmp, &qdev->uc_list_head, list) { if ((memcmp(mac_addr, &tmp->mac, ETHER_ADDR_LEN) == 0) && + ucast->vni == tmp->vni && ucast->vlan == tmp->vlan) { DP_ERR(edev, "Unicast MAC is already added" " with vlan = %u, vni = %u\n",