Thread (11 messages) 11 messages, 3 authors, 2017-07-01

Re: [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

From: Thomas Monjalon <hidden>
Date: 2017-07-01 10:56:47

07/06/2017 19:20, Ferruh Yigit:
On 5/11/2017 12:51 PM, Gowrishankar wrote:
quoted
From: Gowrishankar Muthukrishnan <redacted>

In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf
always into alloc_q, which is excessively leading too many rte_pktmbuf_
free() when alloc_q is contending at high packet rate (for eg 10Gig data).
In a situation when alloc_q fifo can only accommodate very few (or zero)
mbuf, create only what needed and add in fifo.

With this patch, we could stop random network stall in KNI at higher packet
rate (eg 1G or 10G data between vEth0 and PMD) sufficiently exhausting
alloc_q on above condition. I tested i40e PMD for this purpose in ppc64le.

Changes:
 v2 - alloc_q free count calculation corrected.
      line wrap fixed for commit message.

Signed-off-by: Gowrishankar Muthukrishnan <redacted>
Acked-by: Ferruh Yigit <redacted>
Applied with this title:
	"kni: allocate no more mbuf than empty slots in queue"
Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help