Thread (3 messages) 3 messages, 3 authors, 2017-07-01
STALE3314d

[PATCH] vhost: fix MTU device feature check

From: Maxime Coquelin <hidden>
Date: 2017-06-29 07:58:10
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

The MTU feature support check has to be done against MTU
feature bit mask, and not bit position.

Cc: stable@dpdk.org
Fixes: 72e8543093df ("vhost: add API to get MTU value")

Signed-off-by: Maxime Coquelin <redacted>
---

This is a follow-up of Ivan's patch, which made me check I didn't
introduced same bug elsewhere.

 lib/librte_vhost/vhost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
index 19c5a43..653152f 100644
--- a/lib/librte_vhost/vhost.c
+++ b/lib/librte_vhost/vhost.c
@@ -272,7 +272,7 @@ rte_vhost_get_mtu(int vid, uint16_t *mtu)
 	if (!(dev->flags & VIRTIO_DEV_READY))
 		return -EAGAIN;
 
-	if (!(dev->features & VIRTIO_NET_F_MTU))
+	if (!(dev->features & (1ULL << VIRTIO_NET_F_MTU)))
 		return -ENOTSUP;
 
 	*mtu = dev->mtu;
-- 
2.9.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help