Re: [PATCH v5 1/7] bus: fix bus name registration
From: Jan Blunck <hidden>
Date: 2017-06-27 19:19:14
On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet [off-list ref] wrote:
The default bus registration function should not result in buses registering with double quotes within their names.
This is breaking expectations with users. All other registration macro
pass the names through the stringification. The problem is that you
pass in the name as a string already ("PCI" instead of PCI).
quoted hunk ↗ jump to hunk
Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet <redacted> --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index fcc2442..b220299 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h@@ -254,7 +254,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); #define RTE_REGISTER_BUS(nm, bus) \ static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ {\ - (bus).name = RTE_STR(nm);\ + (bus).name = nm;\ rte_bus_register(&bus); \ } --2.1.4