Re: [PATCH v2 3/6] net/vmxnet3: Generate link-state change notifications
From: Ferruh Yigit <hidden>
Date: 2017-06-27 13:52:56
On 6/15/2017 1:16 PM, Charles (Chas) Williams wrote:
From: Robert Shearman <redacted> Generate link-state change notifications by listening to interrupts generated by the device. Make use of the existing vmxnet3_process_events function that was compiled out, but change it to call vmxnet3_dev_link_update on a VMXNET3_ECR_LINK event and to not be so noisy in its log messages. Enable interrupts on starting the device, using a new helper function, vmxnet3_enable_intr, based on vmxnet3_disable_intr and validated against the FreeBSD driver. Keep track of the number of interrupts registered for to avoid hardcoding these in vmxnet3_enable/disable_intr and to provision for any future rxq intr support. Factor out the guts of vmxnet3_dev_link_update minus the started check to allow the new function to be called from vmxnet3_dev_start in the lsc-enabled case to ensure that the link state is correctly set from the actual state at that point. Signed-off-by: Robert Shearman <redacted>
It is close to the integration deadline, and all patches in the set acked except this one, I am for getting the set and if any issue found related LSC, fix it after integration deadline. If there is an objection to get the patchset, please comment soon. Thanks, ferruh