Thread (65 messages) read the whole thread 65 messages, 6 authors, 2017-08-18

Re: [PATCH v3 8/8] mk: always rebuild in the same order

From: Luca Boccassi <hidden>
Date: 2017-06-27 10:41:39

On Tue, 2017-06-27 at 01:22 +0200, Thomas Monjalon wrote:
23/06/2017 20:41, lboccass@brocade.com:
quoted
From: Luca Boccassi <redacted>

In order to achieve reproducible builds, always check dependencies
in
the same order.

Signed-off-by: Luca Boccassi <redacted>
---
 mk/internal/rte.compile-pre.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
It seems something is missing in this patch,
because it is always rebuilding all on the second build.
Indeed, thanks for spotting my mistake!

Sorting before comparing was changing the compared strings, so that was
not working. Duh!
Moving the sort as the "outer" call solves the problem, now rebuilds
correctly skip already built objects.

-- 
Kind regards,
Luca Boccassi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help