Re: [PATCH 2/2] app/testpmd: add support for different aggregation mode in IEEE802.3ad bonding
From: Wu, Jingjing <hidden>
Date: 2017-06-20 02:18:14
From: Wu, Jingjing <hidden>
Date: 2017-06-20 02:18:14
-----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod Sent: Friday, May 26, 2017 10:35 PM To: Doherty, Declan <redacted> Cc: dev@dpdk.org; Mrzyglod, DanielX T <redacted> Subject: [dpdk-dev] [PATCH 2/2] app/testpmd: add support for different aggregation mode in IEEE802.3ad bonding This patch add support for different aggregator modes in similar manner that is provided in linux kernel. testpmd> set bonding agg_mode <port_id> <agg_name> show bonding config testpmd> <port_id> Signed-off-by: Daniel Mrzyglod <redacted>
Here are my comments: 1. title looks too long 2. New commands or update need to be added to help display located at cmd_help_long_parsed. 3. You also need to update the testpmd doc. Thanks Jingjing