Thread (19 messages) 19 messages, 2 authors, 2017-06-12

Re: [PATCH 1/5] net/szedata2: refactor ibuf and obuf names

From: Matej Vido <hidden>
Date: 2017-05-31 08:32:03

On 29.05.2017 14:40, Ferruh Yigit wrote:
On 5/26/2017 7:05 PM, Matej Vido wrote:
quoted
Signed-off-by: Matej Vido <redacted>
Hi Matej,

Overall patchset looks good to me, but can you please provide a little
more information in commit logs, please check comments on patches.

For this patch, it seems refactor naming is removing "cgmii", what is
the reason of this, is cgmii no more true or adding different interface?

Thanks,
ferruh
Hi Ferruh,

ok, I will address the comments in v2.

"cgmii" was too specific. There can be different ibuf/obuf modules in 
different firmwares. But the address space definition is the same for 
all ibuf/obuf modules in all firmwares so this patch makes the name 
general (and also shorter).

Regards,
Matej
quoted
---
  drivers/net/szedata2/rte_eth_szedata2.c |   80 +++++++++++++++---------------
  drivers/net/szedata2/rte_eth_szedata2.h |   48 +++++++++---------
  2 files changed, 64 insertions(+), 64 deletions(-)
<...>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help