Re: [PATCH v2 07/20] bus/fslmc: export qbman results in map file
From: Ferruh Yigit <hidden>
Date: 2017-05-15 16:55:56
From: Ferruh Yigit <hidden>
Date: 2017-05-15 16:55:56
On 5/15/2017 1:37 PM, Hemant Agrawal wrote:
Signed-off-by: Hemant Agrawal <redacted> --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map index 2db0fce..6e7b94d 100644 --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map@@ -49,3 +49,11 @@ DPDK_17.05 { local: *; }; + +DPDK_17.08 { + global: + + qbman_result_SCN_state_in_mem; + + local: *; +};
Syntax should be:
DPDK_17.08 {
global:
qbman_result_SCN_state_in_mem;
} DPDK_17.05;
No "local: *", and previous group (DPDK_17.05) after "}".
But again, it would be nice if you can document in commit log, why
exporting this variable required now?
Thanks,
ferruh