Re: [PATCH v2 1/2] net/sfc: choose datapaths after probe and before attach
From: Ferruh Yigit <hidden>
Date: 2017-03-31 15:14:34
From: Ferruh Yigit <hidden>
Date: 2017-03-31 15:14:34
On 3/29/2017 5:59 PM, Andrew Rybchenko wrote:
Datapath choice requires NIC capabilities knowledge and, therefore,
should be done after probe. Whereas NIC resources estimation needs
to know chosen datapath (e.g. if Tx datapath is going to use TSO).
Fixes: 8221da743f58 ("net/sfc: factor out libefx-based Rx datapath")
Signed-off-by: Andrew Rybchenko <redacted>
---
It could be squashed into corresponding patch, but unfortunately it
happens with conflicts due to sa->state check removal from
sfc_eth_dev_set_ops() where nearby lines are added after 8221da743f58.
I think the bug is not major, so it could wait for rc1 and applied as
fixes.Applied to dpdk-next-net/master, thanks. (Instead of squash, applied as seperata patch, fixes commit needs to be fixed when merged into main repo)