Thread (72 messages) 72 messages, 6 authors, 2017-04-04
STALE3361d REVIEWED: 1 (0M)

[PATCH v4 5/6] cfgfile: increase local buffer size for max name and value

From: Allain Legacy <hidden>
Date: 2017-03-30 18:54:40
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

From: Joseph Richard <redacted>

When parsing a ini file with a "key = value" line that has both "key" and
"value" sized to the maximum allowed length causes a parsing failure.  The
internal "buffer" variable should be sized at least as large as the maximum
for both fields.  This commit updates the local array to be sized to hold
the max name, max value, " = ", and the nul terminator.

Signed-off-by: Allain Legacy <redacted>
Acked-by: Keith Wiles <redacted>
---
 lib/librte_cfgfile/rte_cfgfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index e4a3885b7..4ef7decb3 100644
--- a/lib/librte_cfgfile/rte_cfgfile.c
+++ b/lib/librte_cfgfile/rte_cfgfile.c
@@ -148,7 +148,7 @@ rte_cfgfile_load_with_params(const char *filename, int flags,
 	int allocated_entries = 0;
 	int curr_section = -1;
 	int curr_entry = -1;
-	char buffer[256] = {0};
+	char buffer[CFG_NAME_LEN + CFG_VALUE_LEN + 4] = {0};
 	int lineno = 0;
 	struct rte_cfgfile *cfg = NULL;
 
-- 
2.12.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help