Thread (6 messages) 6 messages, 3 authors, 2017-04-03

Re: [PATCH] net/mlx5: remove not needed query if and rd from create qp

From: Yongseok Koh <hidden>
Date: 2017-03-30 17:03:50

Hi,
On Mar 30, 2017, at 1:06 AM, Shahaf Shuler [off-list ref] wrote:

Since mlx5 PMD data path is on top of PRM, such verbs calls are
no longer needed.

Signed-off-by: Shahaf Shuler <redacted>
Acked-by: Nelio Laranjeiro <redacted>
Acked-by: Yongseok Koh <redacted>

I ack the code change but one small suggestion regarding the commit header.
It looks like 'if' means interface, 'rd' means the Resource Domain, and
'qp' means the Queue Pair. which are all mellanox specific terms and
acronyms. My suggestion is:

net/mlx5: remove unnecessary Verbs library calls

And how about moving the details into the message body:

Remove unnecessary interface queries and the Resource Domain when creating
the Queue Pair. Since mlx5 PMD data path is on top of native APIs, such
Verbs library calls are no longer needed.

Thanks,
Yongseok
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help