Re: [PATCH v2 36/46] net/liquidio: add API to set MTU
From: Ferruh Yigit <hidden>
Date: 2017-03-21 12:24:52
On 3/2/2017 11:32 AM, Shijith Thotton wrote:
Signed-off-by: Shijith Thotton <redacted> Signed-off-by: Jerin Jacob <redacted> Signed-off-by: Derek Chickles <redacted> Signed-off-by: Venkat Koppula <redacted> Signed-off-by: Srisivasubramanian S <redacted> Signed-off-by: Mallesham Jatharakonda <redacted>
<...>
static int
+lio_dev_change_vf_mtu(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
+{
+ struct lio_device *lio_dev = LIO_DEV(eth_dev);
+
+ PMD_INIT_FUNC_TRACE();
+
+ if (!lio_dev->intf_open) {
+ lio_dev_err(lio_dev, "Port %d down, can't change MTU\n",
+ lio_dev->port_id);
+ return -EINVAL;
+ }
+
+ /* Limit the MTU to make sure the ethernet packets are between
+ * ETHER_MIN_MTU bytes and PF's MTU
+ */
+ if ((new_mtu < ETHER_MIN_MTU) ||
+ (new_mtu > lio_dev->linfo.link.s.mtu)) {
+ lio_dev_err(lio_dev, "Invalid MTU: %d\n", new_mtu);
+ lio_dev_err(lio_dev, "Valid range %d and %d\n",
+ ETHER_MIN_MTU, lio_dev->linfo.link.s.mtu);
+ return -EINVAL;
+ }
+
+ return 0;
+}Is this really sets the MTU? "new_mtu" seems not used, except limit check, an lio_send_ctrl_pkt() required perhaps?