Thread (14 messages) 14 messages, 4 authors, 2017-04-01

Re: [PATCH] net/i40e: enable statistic reset for VF

From: Thomas Monjalon <hidden>
Date: 2017-03-16 16:03:33

2017-02-23 13:27, Qi Zhang:
 static void
+i40evf_dev_stats_reset(struct rte_eth_dev *dev)
+{
+	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+	/* only DPDK PF support this */
+	if (vf->version_major == I40E_DPDK_VERSION_MAJOR) {
+		if (i40evf_reset_statistics(dev))
+			PMD_DRV_LOG(ERR, "Reset statistics failed");
+	}
+}
One more SR-IOV feature not supported with a Linux PF.
The basic stats feature must be marked as partially supported in
	doc/guides/nics/features/i40e_vf.ini
See also this email:
	http://dpdk.org/ml/archives/dev/2017-March/060063.html

I wonder whether we should allow such divergence between PF
implementations. Intel committed to avoid such fragmentation
and keep the SR-IOV messaging standard but it does not happen.
It is said that we must allow fast innovation in DPDK space.
I agree but we should also target a good usability of the VF drivers,
allowing to replace the PF implementations as needed.

Here is my suggestion: let's accept a VF feature only if the PF support
is submitted to both dpdk.org and kernel.org mailing lists.
I ask to add this topic to the next techboard meeting.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help