Thread (3 messages) read the whole thread 3 messages, 3 authors, 2017-03-10

Re: [PATCH] app/testpmd: Fix typos

From: Thomas Monjalon <hidden>
Date: 2017-03-10 13:14:10

2017-02-28 17:20, Mcnamara, John:
quoted
fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpecho.c,
app/test-pmd/testpmd.c

Signed-off-by: Nirmoy Das <redacted>

Hi Nirmoy,

Thanks for that.

Just a small heads-up since this is your first patch. The subject line should
be lowercase (apart from known abbreviations) and there is no need to list
the files in the body since git will record that anyway. Have a look at
the contribution guidelines for some more pointers:

http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line

Apart from that, thanks for the patch.

Acked-by: John McNamara <redacted>
Applied, thanks

Nirmoy, we are looking for reviewers with a good english reading ;)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help