Re: [PATCH 03/38] net/nfp: use library function for DMA zone reserve

On Fri, Mar 10, 2017 at 8:03 AM, Shreyansh Jain [off-list ref] wrote:

On Monday 06 March 2017 03:29 PM, Jan Blunck wrote:

quoted

-/* Creating memzone for hardware rings. */
-static const struct rte_memzone *
-ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,
-                     uint16_t queue_id, uint32_t ring_size, int
socket_id)
-{
-       char z_name[RTE_MEMZONE_NAMESIZE];
-       const struct rte_memzone *mz;
-
-       snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d",
-                dev->driver->pci_drv.driver.name,
-                ring_name, dev->data->port_id, queue_id);
-
-       mz = rte_memzone_lookup(z_name);
-       if (mz)
-               return mz;
-
-       return rte_memzone_reserve_aligned(z_name, ring_size, socket_id,
0,
-                                          NFP_MEMZONE_ALIGN);
-}
-

This change is not part of the eth_driver removal process. Isn't it?

I would suggest this should be a separate series all together. This is
valid for Patch 0004 as well.

It is removing a dependency on eth_driver (see
dev->driver->pci_drv.driver.name). Therefore even if I separate it
this series would depend on it.

Thanks for reviewing,
Jan