Re: [PATCH 4/4] net/i40e: refine consistent tunnel filter
From: Xing, Beilei <hidden>
Date: 2017-03-09 06:11:44
-----Original Message----- From: Yigit, Ferruh Sent: Wednesday, March 8, 2017 11:51 PM To: Xing, Beilei <redacted>; Wu, Jingjing <redacted> Cc: Zhang, Helin <redacted>; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter On 3/3/2017 9:31 AM, Beilei Xing wrote:quoted
Add i40e_tunnel_type enumeration type to refine consistent tunnel filter, it will be esay to add new tunnel type fors/esay/easyquoted
i40e. Signed-off-by: Beilei Xing <redacted><...>quoted
/** + * Tunnel type. + */ +enum i40e_tunnel_type { + I40E_TUNNEL_TYPE_NONE = 0, + I40E_TUNNEL_TYPE_VXLAN, + I40E_TUNNEL_TYPE_GENEVE, + I40E_TUNNEL_TYPE_TEREDO, + I40E_TUNNEL_TYPE_NVGRE, + I40E_TUNNEL_TYPE_IP_IN_GRE, + I40E_L2_TUNNEL_TYPE_E_TAG, + I40E_TUNNEL_TYPE_MAX, +};Same question here, there is already "rte_eth_tunnel_type", why driver is duplicating the structure?
Same with " struct i40e_tunnel_filter_conf ", to avoid ABI change, we create it in PMD to add new tunnel type easily, like MPLS.
<...>