Re: [PATCH v3] proc-info: added collectd-format and host-id options.

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tahhan, Maryam
Sent: Friday, March 3, 2017 1:32 PM
To: Korynkevych, RomanX <redacted>; dev@dpdk.org
Cc: Korynkevych, RomanX <redacted>
Subject: Re: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id options.

quoted

From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roman Korynkevych
Sent: Wednesday, March 1, 2017 4:27 PM
To: dev@dpdk.org
Cc: Korynkevych, RomanX <redacted>
Subject: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id
options.

Extended proc-info application to send DPDK port statistics to STDOUT in the
format expected by collectd exec plugin. Added HOST ID option to identify the
host DPDK process is running on when multiple instance of DPDK are running in
parallel. This is needed for the barometer project in OPNFV.

Signed-off-by: Roman Korynkevych <redacted>

Reviewed-by: Maryam Tahhan <redacted>

Hi Roman,

Just a few pointers on DPDK patch rework / review practice;

- CC people involved in discussion / review of previous versions
- If somebody review / acks your patch, with a request for simple-error rework,
  it is allowed to include their Reviewed-by / acked by. Note the changes must
  be minor, or keeping the Review/Ack suggested by the person[1]
- When updating a patch, it is good practice to summarize the
  changes made under the --- line, so it is easier for reviewers
  to see changes made.

That said, no problem, just something to keep in mind for next patches :)
Nice work,

Acked-by: Harry van Haaren <redacted>


[1] http://dpdk.org/dev/patchwork/patch/20898/