Re: [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers
From: Lu, Wenzhuo <hidden>
Date: 2017-02-28 01:07:34
From: Lu, Wenzhuo <hidden>
Date: 2017-02-28 01:07:34
Hi Billy,
-----Original Message----- From: Billy McFall [mailto:bmcfall@redhat.com] Sent: Saturday, January 28, 2017 2:38 AM To: thomas.monjalon@6wind.com; Lu, Wenzhuo; olivier.matz@6wind.com Cc: dev@dpdk.org; Billy McFall Subject: [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers Add support to the e1000 igb driver for the new API to force free consumed buffers on Tx ring. e1000 igb driver does not implement a tx_rs_thresh to free mbufs, it frees a slot in the ring as needed, so a new function needed to be written.
There's another question about this commit log. As we know tx_rs_thresh is not supported by igb. But I think it can be implemented. Your idea is to add an API, so APP can free the buffers explicitly. It's a different idea with threshold, right? Seems this log is a little misleading.