Thread (5 messages) 5 messages, 2 authors, 2017-02-26

Re: checkpatch.pl inconsistent results

From: Legacy, Allain <hidden>
Date: 2017-02-26 17:32:05

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Sunday, February 26, 2017 11:42 AM
To: Legacy, Allain
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] checkpatch.pl inconsistent results
... 
Yes it has been discussed few times.
I don't see any issue at having different results, because the main benefit of
checkpatch is to help in reviews. If a new tool or version helps to have a
better code, it's fine but it is probably not a big issue.
I do not like the idea of saving a copy of checkpatch in DPDK (we won't
maintain it and it could be used by several DPDK repositories).
I think we can add an automatic download from kernel.org if the script is not
found. However it won't fix the versioning.
Ok, I guess what I meant was that the automatic download could fetch the tool from a specific commit id (not master), and we could update the commit id that we want to use on a periodic basis.  That way at least everyone is at the same baseline at any given snapshot in time and results would be reproducible if we had to revert back to an earlier stable branch to port a fix.  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help