Re: [PATCH] net/ixgbevf: reset hardware when stoppingport

Hi, Wenzhuo

Sorry, Now I just notice the email is related with me.

Seems the commit log doesn't match the code change.
This change cannot resolve the described problem. The problem is VF doesn't handle the PF reset event. 
Moving  the hw_reset from close to stop doesn't help and not necessary. Because  PF has already reset VF stuff during  
resetting itself, that's why VF  not working anymore.

Explain the problem of this issue.
1) it seems VF have to call ixgbe_reset_hw() when it receive PF reset event. 
it seems VF is client and PF is server and VF has to reset the register on his side, after PF has reset the register on his side.

2) with this patch, when VF receive the event after PF is set link down, it will call ixgbe_reset_hw() in ixgbevf_dev_close().
and we have validate this patch


Thanks
Fengtian
 
 
------------------ Original ------------------
From:  "Lu, Wenzhuo"<redacted>;
Date:  Fri, Feb 24, 2017 01:21 PM
To:  "Olivier Matz"<redacted>; "dev@dpdk.org"<redacted>; "Zhang, Helin"<redacted>; "Ananyev, Konstantin"<redacted>; 
Cc:  "Guo Fengtian"<redacted>; "stable@dpdk.org"<redacted>; "David Marchand"<redacted>; 
Subject:  RE: [dpdk-dev] [PATCH] net/ixgbevf: reset hardware when stoppingport

 
Hi Olivier, Fengtian,

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz
Sent: Thursday, January 12, 2017 12:52 AM
To: dev@dpdk.org; Zhang, Helin; Ananyev, Konstantin
Cc: Guo Fengtian; stable@dpdk.org; David Marchand
Subject: [dpdk-dev] [PATCH] net/ixgbevf: reset hardware when stopping port

From: Guo Fengtian <redacted>

When PF triggers a reset, VF port must acknowledge it by calling
ixgbe_reset_hw().

Before this patch, the port link status, speed and duplex are invalid (all set
to 0).

The patch move the call to ixgbe_reset_hw() from ixgbevf_dev_close() to
ixgbevf_dev_stop(), so that after a port restart on the VM, the link status is
properly marked down, with correct speed and duplex.

Fixes: f0160874c041 ("ixgbe: various updates")

CC: stable@dpdk.org
Signed-off-by: Guo Fengtian <redacted>
Signed-off-by: David Marchand <redacted>
Signed-off-by: Olivier Matz <redacted>
---

Hi,

The use case for this problem was described some time ago, see:
http://dpdk.org/ml/archives/dev/2015-December/030067.html

It is also part of 2.2 release note:
http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/release_2_2.rst#n4
71

Regards,
Olivier

Seems the commit log doesn't match the code change.
This change cannot resolve the described problem. The problem is VF doesn't handle the PF reset event. 
Moving the hw_reset from close to stop doesn't help and not necessary. Because PF has already reset VF stuff during  resetting itself, that's why VF not working anymore.