Thread (10 messages) 10 messages, 4 authors, 2017-02-14

Re: [PATCH 2/3] net/cxgbe: remove unused variable usage

From: Yuanhan Liu <hidden>
Date: 2017-02-14 06:10:24

On Thu, Jan 26, 2017 at 11:05:22AM +0000, Ferruh Yigit wrote:
On 1/26/2017 4:41 AM, Rahul Lakkireddy wrote:
quoted
On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote:
quoted
On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
quoted
Found with clang static analysis:
drivers/net/cxgbe/sge.c:900:3: warning:
Value stored to 'in_use' is never read
        in_use += q->size;
        ^         ~~~~~~~

Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
This fixes line seems to be wrong.  Should be:
quoted
quoted
quoted
Signed-off-by: Emmanuel Roullit <redacted>
quoted
Fixes: 4a01078b4fd1 ("cxgbe: add Tx support")
Cc: stable@dpdk.org
I doubt the necessary of picking it to a stable release: it doesn't fix
a real bug after all. Therefore, I will drop it for v16.11.1.

	--yliu 
Acked-by: Rahul Lakkireddy <redacted>


Applied to dpdk-next-net/master, thanks.

(patch 2/3 and 3/3 merged)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help