Thread (115 messages) 115 messages, 10 authors, 2017-03-10

Re: [PATCH v9 1/7] lib: add information metrics library

From: Mcnamara, John <hidden>
Date: 2017-01-31 13:13:14

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
Sent: Monday, January 30, 2017 3:50 PM
To: Horton, Remy <redacted>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics
library

Hi Remy,
quoted
This patch adds a new information metric library that allows other
modules to register named metrics and update their values. It is
intended to be independent of ethdev, rather than mixing ethdev and
non-ethdev information in xstats.
I'm still not convinced by this library, and this introduction does not
help a lot.

I would like to thanks Harry for the review of this series.
If we had more opinions or enthousiasm about this patch, it would be
easier to accept this new library and assert it is the way to go.
Hi,

The RFCs for this library (initially two, merged into one) have been up since October, during the 16.11 timeframe. Comments were made and applied.

   http://dpdk.org/ml/archives/dev/2016-October/049571.html
   http://dpdk.org/ml/archives/dev/2016-October/048390.html

I'm concerned that these new comments/reservations are coming in very, very late in the 17.02 release cycle.

If there hasn't been a lot of opinions or enthusiasm then equally there hasn't been other reservations. If there had been we would have addressed them.

It could be a matter of technical board discussion if we had a clear
explanation of the needs, the pros and cons of this design.
We are happy to have the design discussed at the Technical Board. We would also like the inclusion of this library in RC3 to be discussed since that is still our desired outcome. 

We have, as any other company would have, customers awaiting features, developers committed to timelines, and testing and integration roadmaps. Blocking or delaying features at the last moment isn't an effective model that we, and I'm sure other companies, can work with.

As such, it is probably best, that all current and future RFCs are reviewed at the Technical Board and that the board gives an indication on whether the proposal is acceptable for upstreaming or not. 
The overview for using this library should be given in the prog guide.
We will add a section to the Programmers Guide.

John
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help