Thread (44 messages) 44 messages, 6 authors, 2017-02-01

Re: [PATCH 14/25] eal: do not panic on tailq init

From: Aaron Conole <aconole@redhat.com>
Date: 2017-01-30 16:51:23

Stephen Hemminger [off-list ref] writes:
On Fri, 27 Jan 2017 09:56:52 -0500
Aaron Conole [off-list ref] wrote:
quoted
+ /* no need to TAILQ_REMOVE, we are going to disallow re-attemtps
+			 * for rte_eal_init().  */
Please put multi-line comments in form:
             /*
              * this is a long comment
              * because there really is lots to say
              */
Okay, will do.
In many cases, having shorter comment is the best way to handle these.
Often developer writes long comment for themselves because what ever problem
they saw was urgent. Then comment becomes irrelevant later.

             /* TAILQ_REMOVE not needed, error is already fatal */
I'll fold this in.

Thanks for the review!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help