Re: [PATCH v2] mk: suppress error for reference of packed members
From: Thomas Monjalon <hidden>
Date: 2017-01-25 10:08:25
2017-01-24 22:04, Emmanuel Roullit:
Found with clang build:
error: taking address of packed member 'mlock' of class or structure
'rte_mem_config' may result in an unaligned pointer value
[-Werror,-Waddress-of-packed-member]
Fixes: 29361d4c91ed ("mk: fix build with clang < 3.5")
Fixes: b2bb3a5daaac ("mk: stop on warning only in developer build")I think these references are not correct. The bug is due to a new version of clang, so no Fixes: tag is needed. You should put "clang 4" in the title.
Signed-off-by: Emmanuel Roullit <redacted> --- v2: * Only apply compiler flag on clang >= 4.0
Please use --in-reply-to for grouping v2 patches with v1.
quoted hunk ↗ jump to hunk
--- a/mk/toolchain/clang/rte.toolchain-compat.mk +++ b/mk/toolchain/clang/rte.toolchain-compat.mk +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -ge 40 && echo 1), 1) + CC_PACKED_MEMBER_WERROR := true +endif
quoted hunk ↗ jump to hunk
--- a/mk/toolchain/clang/rte.vars.mk +++ b/mk/toolchain/clang/rte.vars.mk +ifeq ($(CC_PACKED_MEMBER_WERROR),true) +WERROR_FLAGS += -Wno-address-of-packed-member +endif
So you are completely disabling the warning? Can we assume this warning is of no interest?