On Monday 23 January 2017 11:02 PM, Ferruh Yigit wrote:

On 1/23/2017 11:59 AM, Hemant Agrawal wrote:

quoted

add support for fsl-mc bus based dpaa2 pmd driver.

Signed-off-by: Hemant Agrawal <redacted>
---

<...>

quoted

diff --git a/drivers/net/dpaa2/Makefile b/drivers/net/dpaa2/Makefile
new file mode 100644
index 0000000..f85aa9f
--- /dev/null
+++ b/drivers/net/dpaa2/Makefile

<...>

quoted

+
+# library dependencies
+DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_eal lib/librte_ether
+DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_bus_fslmc

Is this dependency correct?

I think yes.
- Without Bus, dpaa2 PMD wouldn't work and being a configurable option,
   user can set CONFIG_RTE_LIBRTE_DPAA2_PMD=n and
   CONFIG_RTE_LIBRTE_DPAA2_PMD=y.

- If you referring to whether lib/librte_bus_fslmc is correct or not, I
   have replied to your response on 16/33 patch. In short, I think this
   is correct assuming that librte_bus_fslmc is valid LIB name and not
   expected to be a folder in lib/

quoted

+
+include $(RTE_SDK)/mk/rte.lib.mk

<...>