Thread (3 messages) 3 messages, 3 authors, 2017-01-17

Re: [PATCH] examples: fix ip_pipeline makefile typo

From: Thomas Monjalon <hidden>
Date: 2017-01-17 17:22:32

2016-11-23 15:43, Ferruh Yigit:
On 11/23/2016 12:56 PM, Ilya Matveychikov wrote:
quoted
Signed-off-by: Ilya V. Matveychikov <redacted>
---
 examples/ip_pipeline/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/Makefile b/examples/ip_pipeline/Makefile
index 5827117..6657237 100644
--- a/examples/ip_pipeline/Makefile
+++ b/examples/ip_pipeline/Makefile
@@ -36,7 +36,7 @@ endif
 # Default target, can be overridden by command line or environment
 RTE_TARGET ?= x86_64-native-linuxapp-gcc

-DIRS-(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
+DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline
No need to fix, this line can be removed completely.

Because of:
VPATH += $(SRCDIR)/pipeline

and files handled in this makefile:
SRCS-$(CONFIG_RTE_LIBRTE_PIPELINE) += pipeline_passthrough.c

When you fix DIR-y, you also need to add a makefile to pipeline folder
and update this makefile. I guess all those are not required. Just
removing that line is easier J
There was no progress on this trivial patch.
So I made what Ferruh suggested and applied in the tree directly:
	http://dpdk.org/commit/45e1c8b

Thanks for the report and the review.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help