Thread (63 messages) 63 messages, 5 authors, 2017-01-17

Re: [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype option

From: Tan, Jianfeng <hidden>
Date: 2017-01-17 05:24:04

-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
Sent: Tuesday, January 17, 2017 1:16 PM
To: Tan, Jianfeng
Cc: dev@dpdk.org; stephen@networkplumber.org; Yao, Lei A
Subject: Re: [PATCH v3 09/10] examples/l3fwd-power: add parse-ptype
option

On Mon, Jan 16, 2017 at 02:47:01PM +0000, Jianfeng Tan wrote:
quoted
+#if (APP_LOOKUP_METHOD == APP_LOOKUP_LPM)
+	if (ptype_l3_ipv4)
+#else
+	// APP_LOOKUP_EXACT_MATCH
No c++ comment.
OK.
Besides, this patchset misses the release note. Also bear in mind I
think this feature deserves a howto doc.
Sorry, I missed that in my stash. Will send a new version with fixing Stephen's comment.

Thanks,
Jianfeng
	--yliu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help