Hello Pablo,

Please check my answers in-line below.

Kind regards
Zbigniew

On 10.01.2017 18:11, De Lara Guarch, Pablo wrote:

Hi Zbigniew,

quoted

-----Original Message-----
From: zbigniew.bodek@caviumnetworks.com
[mailto:zbigniew.bodek@caviumnetworks.com]
Sent: Wednesday, January 04, 2017 5:33 PM
To: dev@dpdk.org
Cc: De Lara Guarch, Pablo; Doherty, Declan;
jerin.jacob@caviumnetworks.com; Zbigniew Bodek
Subject: [PATCH v3 0/8] Add crypto PMD optimized for ARMv8

From: Zbigniew Bodek <redacted>

...

quoted

Zbigniew Bodek (8):
  mk: fix build of assembly files for ARM64
  lib: add cryptodev type for the upcoming ARMv8 PMD
  crypto/armv8: add PMD optimized for ARMv8 processors
  mk/crypto/armv8: add PMD to the build system
  doc/armv8: update documentation about crypto PMD
  crypto/armv8: enable ARMv8 PMD in the configuration
  crypto/armv8: update MAINTAINERS entry for ARMv8 crypto
  app/test: add ARMv8 crypto tests and test vectors

Thanks for this patchset.

Could you change the titles of some of these patches?
The prefix should be "mk:" and not "mk/crypto/armv8", for instance.
The other ones that should be changed are "doc/armv8" -> "doc" and "crypto/armv8: update MAINTAINERS" to "MAINTAINERS:".

I can do this for you, if you are OK with these changes.

I'm OK with the changes and I will appreciate changing those names if 
this is not an inconvenience for you.

Apart from this, can anyone review these changes? I do not have access to an ARM board,
so it is a bit difficult for me to review it.

I would like to add that I can help with the build and installation in 
case the documentation is not sufficient (this would also mean changing 
the documentation).

Thanks,
Pablo