Thread (29 messages) 29 messages, 8 authors, 2017-01-26

Re: [PATCH v2 1/3] eal: add quiet mode to suppress log output to stdout

From: Declan Doherty <hidden>
Date: 2017-01-10 10:49:18

On 05/01/17 15:40, Thomas Monjalon wrote:
2017-01-05 17:49, Slawomir Mrozowicz:
quoted
Add EAL option to suppresses all log output to stdout.

Signed-off-by: Declan Doherty <redacted>
[...]
quoted
 	       "  --"OPT_LOG_LEVEL"         Set default log level\n"
+		"  -s, --"OPT_LOG_STDOUT_SILENT" Silent mode, suppresses log "
+		"output to stdout\n"
How does it behave when the app configure a custom log function which
prints to stdout?

Generally speaking, we should stop adding such options in DPDK and
move this kind of responsibility to the applications (providing some API
and helpers).
Hey Thomas,

this option wouldn't affect a custom log function as the flag this 
controls is only used within by the default Linux log file stream in the 
console_log_write function. Maybe a better option would be to change the 
general behaviour of the default logging function and remove the printf 
to stdout completely and add a generic verbose option applicable to all 
environments which would allow log output to be directed to stdout. I 
did notice that the default behaviour between Linux/BSD does seem to be 
different with Linux defaulting to syslog/stdout and BSD to stderr.

One way or another I would like to able to disable streaming of log 
output to stdout when using the default log stream in Linux, but I'm 
open to suggestions as to the best way of doing this?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help