Thread (21 messages) 21 messages, 4 authors, 2016-12-21

Re: [PATCH v3 4/9] virtio: Don't fill dev_info->driver_name

From: Jan Blunck <hidden>
Date: 2016-12-20 12:40:12

On Tue, Dec 20, 2016 at 1:17 PM, Ferruh Yigit [off-list ref] wrote:
On 12/20/2016 11:11 AM, Jan Blunck wrote:
quoted
This is overwritten in rte_eth_dev_info_get().

Signed-off-by: Jan Blunck <redacted>
Reviewed-by: David Marchand <redacted>
---
 drivers/net/virtio/virtio_ethdev.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 079fd6c..741688e 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
      uint64_t tso_mask;
      struct virtio_hw *hw = dev->data->dev_private;

-     if (dev->pci_dev)
-             dev_info->driver_name = dev->driver->pci_drv.driver.name;
-     else
-             dev_info->driver_name = "virtio_user PMD";
      dev_info->max_rx_queues =
              RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);
      dev_info->max_tx_queues =

This has been already removed in next-net with following commit:
7c6c1857358c ("net: remove dead driver names")
Thanks. Do you want me to rebase against next-net and resend the
series before continuing to review further?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help