Re: [PATCH] net/qede: fix gcc compiler option checks
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-10-28 22:11:51
On Thu, 27 Oct 2016 23:37:57 -0700 Rasesh Mody [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Rasesh Mody <redacted> Using GCC_VERSION to check gcc version and decide whether to include that compiler option. Fixes: ec94dbc57362 ("qede: add base driver") Fixes: ecc7a5a27ffe ("net/qede/base: fix 32-bit build") Signed-off-by: Rasesh Mody <redacted> --- drivers/net/qede/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index 39751e4..29b443d 100644 --- a/drivers/net/qede/Makefile +++ b/drivers/net/qede/Makefile@@ -46,11 +46,11 @@ endif endif ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) -ifeq ($(shell gcc -Wno-unused-but-set-variable -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0) +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable endif CFLAGS_BASE_DRIVER += -Wno-missing-declarations -ifeq ($(shell gcc -Wno-maybe-uninitialized -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0) +ifeq ($(shell test $(GCC_VERSION) -ge 46 && echo 1), 1) CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized endif CFLAGS_BASE_DRIVER += -Wno-strict-prototypes
Does this mean that less compiler checking is done or more? It seems lots of drivers make the excuse: "the base driver comes from another group and is known buggy but can't be fixed" That doesn't reflect well on the quality of the DPDK.