Re: [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV
From: Wu, Jingjing <hidden>
Date: 2016-10-26 14:38:34
quoted hunk ↗ jump to hunk
-----Original Message----- From: Iremonger, Bernard Sent: Wednesday, October 26, 2016 12:51 AM To: dev@dpdk.org; Shah, Rahul R <redacted>; Lu, Wenzhuo [off-list ref]; Dumitrescu, Cristian [off-list ref]; Wu, Jingjing [off-list ref] Cc: Iremonger, Bernard <redacted> Subject: [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV The folowing changes have been made to allow Data Centre Bridge (DCB) configuration when SRIOV is enabled. Modify ixgbe_check_mq_mode function, when SRIOV is enabled, enable mq_mode ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB. Modify ixgbe_dcb_tx_hw_config function, replace the struct ixgbe_hw parameter with a struct rte_eth_dev parameter and handle SRIOV enabled. Modify ixgbe_dev_mq_rx_configure function, when SRIOV is enabled, enable mq_mode ETH_MQ_RX_VMDQ_DCB. Modify ixgbe_configure_dcb function, revise check on dev->data->nb_rx_queues. Signed-off-by: Rahul R Shah <redacted> Signed-off-by: Bernard Iremonger <redacted> Acked-by: Wenzhuo Lu <redacted> --- drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++++++----- drivers/net/ixgbe/ixgbe_rxtx.c | 35 ++++++++++++++++++++++------------- 2 files changed, 28 insertions(+), 18 deletions(-)diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 4ca5747..4d5ce83 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c@@ -1977,6 +1977,9 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev) /* check multi-queue mode */ switch (dev_conf->rxmode.mq_mode) { case ETH_MQ_RX_VMDQ_DCB: + PMD_INIT_LOG(INFO, "ETH_MQ_RX_VMDQ_DCB mode supported in SRIOV"); + dev->data->dev_conf.rxmode.mq_mode = ETH_MQ_RX_VMDQ_DCB;
This line is duplicated, mq_mode is ETH_MQ_RX_VMDQ_DCB already. And it's better to check if the nb_queue is valid.