Thread (9 messages) 9 messages, 3 authors, 2016-09-23

Re: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking

From: De Lara Guarch, Pablo <hidden>
Date: 2016-09-23 17:11:15

-----Original Message-----
From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
Sent: Friday, September 23, 2016 6:52 AM
To: De Lara Guarch, Pablo; Richardson, Bruce
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC
addresses tweaking



On 09/21/2016 11:53 PM, De Lara Guarch, Pablo wrote:
quoted
quoted
-----Original Message-----
From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
Sent: Tuesday, July 26, 2016 8:56 AM
To: Richardson, Bruce; De Lara Guarch, Pablo
Cc: dev@dpdk.org; Maxime Coquelin
Subject: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC
addresses tweaking

This series adds a new option to enable/disable MAC addresses tweaking
in
quoted
quoted
l2fwd example.

Doing that, we can enable basic VM 2 VM communication easily, without
external projects dependencies, nor real NIC (as with vhost example).

Example of cli with vhost-user:

#l2fwd -c f --socket-mem=1024 \
	--vdev 'eth_vhost0,iface=/tmp/vhost-user1,queues=1' \
	--vdev 'eth_vhost1,iface=/tmp/vhost-user2,queues=1' \
	-- -p3 --no-mac-tweaking

By default, MAC addresses tweaking remains enabled, but maybe we
could
quoted
quoted
consider having it disabled by default to be consistent with l2fwd-cat
for example.

Maxime Coquelin (2):
  examples/l2fwd: Add new option to enable/disable MAC addresses
    tweaking
  doc: l2fwd: document new --[no-]mac-tweaking option

 doc/guides/sample_app_ug/img/l2_fwd_vm2vm.svg      | 311
+++++++++++++++++++++
 .../sample_app_ug/l2_forward_real_virtual.rst      |  24 +-
 examples/l2fwd/main.c                              |  39 ++-
 3 files changed, 358 insertions(+), 16 deletions(-)
 create mode 100644 doc/guides/sample_app_ug/img/l2_fwd_vm2vm.svg

--
2.7.4
Acked-by: Pablo de Lara <redacted>
Thanks Pablo,

Just sent the v2, but didn't applied your Ack since I did some changes,
even though trivial ones.
This looks good to me, as well.

Pablo
Regards,
Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help