Thread (231 messages) 231 messages, 9 authors, 2016-11-11

Re: [PATCH v3 13/15] ether: extract function eth_dev_get_driver_name

From: Hunt, David <hidden>
Date: 2016-09-15 13:03:22


On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Jan Viktorin <redacted>
Signed-off-by: Shreyansh Jain <redacted>
Signed-off-by: Hemant Agrawal <redacted>
---
  lib/librte_ether/rte_ethdev.c | 15 ++++++++++++++-
  1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 104ea4a..4fa65ca 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -2568,6 +2568,17 @@ rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data)
  	return 0;
  }
  
+static inline
+const char *eth_dev_get_driver_name(const struct rte_eth_dev *dev)
+{
+	if (dev->pci_dev) {
+		return dev->driver->pci_drv.driver.name;
+	}
+
+	RTE_VERIFY(0);
Same comment as last patch, maybe add an rte_panic with more descriptive 
error message.
quoted hunk ↗ jump to hunk
+	return NULL;
+}
+
  const struct rte_memzone *
  rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
  			 uint16_t queue_id, size_t size, unsigned align,
@@ -2575,9 +2586,11 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
  {
  	char z_name[RTE_MEMZONE_NAMESIZE];
  	const struct rte_memzone *mz;
+	const char *drv_name;
  
+	drv_name = eth_dev_get_driver_name(dev);
  	snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d",
-		 dev->driver->pci_drv.driver.name, ring_name,
+		 drv_name, ring_name,
  		 dev->data->port_id, queue_id);
  
  	mz = rte_memzone_lookup(z_name);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help