Thread (19 messages) 19 messages, 6 authors, 2016-10-04

Re: [PATCH v1] dpdk-devbind.py: Virtio interface issue.

flat view

From: Mcnamara, John <hidden>
Date: 2016-08-25 10:27:26

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Thursday, August 25, 2016 11:19 AM
To: Mcnamara, John <redacted>
Cc: dev@dpdk.org; souvikdey33 <redacted>; nhorman@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface
issue.

2016-08-25 09:51, Mcnamara, John:
quoted
The word fix on the command line normally means you should add a
"Fixes" line to the body but in this case the issue was probably
always there (or at least since virtio support was added) so you can
probably omit it.

Even if it has always been there, we need to know the commit origin.
The "Fixes:" line makes things clear and helps when backporting.
Thanks
In that case the fixline should be:

    Fixes: 629395b063e8 ("igb_uio: remove PCI id table")

John
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help