Re: [PATCH 1/3] net/ixgbe: move PCI device ids to the driver

On Mon, Aug 8, 2016 at 11:10 AM, Ferruh Yigit [off-list ref] wrote:

On 8/8/2016 7:36 AM, David Marchand wrote:

quoted

The only thing that bothers me using this ("unsynchronised") internal
pci device list is that, if people were using the ethtool part of kni,
there would now be devices that won't be recognised anymore.
Is it intentional ?

I am aware that the list changed, but wasn't sure about updating the
list in drivers or not.

If a device is not listed in driver's pci device id table, it may not be
supported, so ethtool may give wrong output, or it may just be missing,
this is hard to know without testing (although this was the case before
this patch)

Since it is easy to add new id, and we are at the beginning of the
release, I was thinking if somebody reports KNI ethotool support is
missing for a specific device, we can add it instead of adding all by
default.

Ok for me and with this we can know if this ethtool part is used :-)


-- 
David Marchand