Thread (3 messages) 3 messages, 2 authors, 2016-08-31

[PATCH] kni: error release device list head could cause a kernel crash.

flat view
STALE3694d

From: 周杨超 <hidden>
Date: 2016-08-06 11:20:02

From 3edca1e3194959ba26a6c36143f8423009661b11 Mon Sep 17 00:00:00 2001
From: zhouyangchao <redacted>
Date: Sat, 6 Aug 2016 19:14:51 +0800
Subject: [PATCH] kni: error release device list head could cause a kernel crash.

Signed-off-by: zhouyangchao <redacted>
---
 lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c
b/lib/librte_eal/linuxapp/kni/kni_misc.c
index ae8133f..a49924b 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -276,8 +276,8 @@ kni_release(struct inode *inode, struct file *file)
 #ifdef RTE_KNI_VHOST
  kni_vhost_backend_release(dev);
 #endif
- kni_dev_remove(dev);
  list_del(&dev->list);
+ kni_dev_remove(dev);
  }
  up_write(&knet->kni_list_lock);
@@ -613,8 +613,8 @@ kni_ioctl_release(struct net *net,
 #ifdef RTE_KNI_VHOST
  kni_vhost_backend_release(dev);
 #endif
- kni_dev_remove(dev);
  list_del(&dev->list);
+ kni_dev_remove(dev);
  ret = 0;
  break;
  }
--
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help