Thread (9 messages) flat view 9 messages, 3 authors, 2016-07-21

Re: [PATCH] vhost: fix driver unregister for client mode

From: Yuanhan Liu <hidden>
Date: 2016-07-20 12:34:56

On Wed, Jul 20, 2016 at 11:32:43AM +0300, Ilya Maximets wrote:
Currently while calling of 'rte_vhost_driver_unregister()' connection
to QEMU will not be closed. This leads to inability to register driver
again and reconnect to same virtual machine.

This scenario is reproducible with OVS. While executing of the following
command vhost port will be re-created (will be executed
'rte_vhost_driver_register()' followed by 'rte_vhost_driver_unregister()')
network will be broken and QEMU possibly will crash:

	ovs-vsctl set Interface vhost1 ofport_request=15

Fix this by closing all established connections on driver unregister and
removing of pending connections from reconnection list.

Fixes: 64ab701c3d1e ("vhost: add vhost-user client mode")
Signed-off-by: Ilya Maximets <redacted>
Ilya, Thanks a lot for the test and fix. It looks good to me. But
somehow I would like have a test tomorrow.

	--yliu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help