Re: [PATCH] doc: announce API change for virtual device initialization
From: De Lara Guarch, Pablo <hidden>
Date: 2016-07-05 14:55:05
-----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] Sent: Tuesday, July 05, 2016 2:39 PM To: Yigit, Ferruh Cc: dev@dpdk.org; De Lara Guarch, Pablo; Mcnamara, John Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for virtual device initialization 2016-07-05 14:04, Ferruh Yigit:quoted
On 7/4/2016 3:50 PM, Pablo de Lara wrote:quoted
+* The rte_eal_vdev_init function will be changed in 16.11 to return + the port/device id of the device created, instead of 0, when it has been + initialized successfully, so user can use the returned value straight away + to call all the device functions that require that parameter.There is another API rte_eth_dev_attach(), which returns port_id, and is a common wrapper both for pdev and vdev. So with proper devargs this API calls rte_eal_vdev_init() and returns port_id (set in argument) without any extra side effect.I think rte_eth_dev_attach() should be removed from ethdev. Hotplugging a device belongs to device management, i.e. EAL.
Even though rte_eth_dev_attach returns the port id, I think that rte_eal_vdev_init can return the port id anyway (and then, we can remove the call to rte_eth_dev_get_port_by_name in rte_eth_dev_attach).