Re: [PATCH v7 22/25] mlx5: work around spurious compilation errors
From: Bruce Richardson <hidden>
Date: 2016-06-27 12:12:21
On Fri, Jun 24, 2016 at 03:18:01PM +0200, Nelio Laranjeiro wrote:
From: Adrien Mazarguil <redacted>
Since commit "mlx5: resurrect Tx gather support", older GCC versions (such
as 4.8.5) may complain about the following:
mlx5_rxtx.c: In function `mlx5_tx_burst':
mlx5_rxtx.c:705:25: error: `wqe' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
mlx5_rxtx.c: In function `mlx5_tx_burst_inline':
mlx5_rxtx.c:864:25: error: `wqe' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
In both cases, this code cannot be reached when wqe is not initialized.
Considering older GCC versions are still widely used, work around this
issue by initializing wqe preemptively, even if it should not be necessary.
Signed-off-by: Adrien Mazarguil <redacted>Since the previous patch is known to break the build on older compilers, I think it would be better to merge this patch into the previous to prevent the break from occurring in the first place. That will help with any future git-bisects that people run. If there is no objection, and no other issues appear requiring a new rev of this patchset, I'll merge patches 21 and 22 on apply. Regards, /Bruce