Re: [PATCH v2 3/7] pipeline: fix truncated dependency list
From: Dumitrescu, Cristian <hidden>
Date: 2016-06-27 09:20:53
From: Dumitrescu, Cristian <hidden>
Date: 2016-06-27 09:20:53
-----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: Sunday, June 26, 2016 5:42 PM To: Panu Matilainen <redacted> Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list From: Panu Matilainen <redacted> In other libraries, dependency list is always appended to, but in commit 6cbf4f75e059 it with an assignment. This causes the librte_eal dependency added in commit 6cbf4f75e059 to get discarded, resulting in missing dependency on librte_eal.
Acked-by: Cristian Dumitrescu <redacted> Hi Thomas, As discussed in some other email thread, it would also make sense to replace the ':=' operator with '+=' operator in Makefile of rte_port and rte_table as well, do you want us to send a separate patch for this? Thanks, Cristian